feat(util): add markdown format functions to util #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTGAzureX1212
added
w-do-not-merge
github-actions
bot
added
c-util
Gelbpunkt
requested changes
Apr 6, 2024
|
Do you think we need to add the H1, H2, H3, ... formatting? |
yes, i think this should support all of discord's supported markdown, including named links and timestamps |
Promptly added. |
vilgotf
reviewed
May 31, 2024
| fn strikethrough(self) -> Self; | ||
| } | ||
|
|
||
| impl Format for String { |
There was a problem hiding this comment.
I would prefer formatters like twilight_mention::fmt::MentionFormat and twilight_model::user::DiscriminatorDisplay over extension methods.
| @@ -15,6 +15,9 @@ | |||
| #[cfg(feature = "builder")] | |||
| pub mod builder; | |||
|
|
|||
| #[cfg(feature = "format")] | |||
| pub mod format; | |||
There was a problem hiding this comment.
Suggested change
| pub mod format; | |
| pub mod fmt; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2279.
This draft PR explores a potential implementation for markdown formatting functions. It is expected that the implementation would be iterated on for a bit before this is actually merged into main.